Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update last_snapshot_hint file when purge #9060

Merged
merged 6 commits into from
Dec 2, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Dec 1, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix: update last_snapshot_hint file when purge.
add test cases of this modification.

Closes #9040

@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 2, 2022 at 11:52AM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Dec 1, 2022
@dantengsky
Copy link
Member

@dantengsky
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2022

update

✅ Branch has been successfully updated

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 57af75f into databendlabs:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: access to share table MUST handle if the last_snapshot_location_hint file changed case.
3 participants