Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planner): remove SyncTypeChecker #9352

Merged
merged 5 commits into from
Dec 24, 2022
Merged

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Dec 23, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Dec 23, 2022 at 5:14PM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 23, 2022
@sundy-li
Copy link
Member

Why do we need to revert #9290 ?

@andylokandy
Copy link
Collaborator Author

Why do we need to revert #9290 ?

Because Binder requires PlannerContext while FuseTable can only provide TableContext.

@mergify mergify bot merged commit 99d8a20 into datafuselabs:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants