Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqllogictests): Add no-fail-fast support #9391

Merged
merged 4 commits into from Dec 28, 2022

Conversation

xudong963
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

@vercel
Copy link

vercel bot commented Dec 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Dec 28, 2022 at 8:25AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Dec 28, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Dec 28, 2022

Please add an args for this. We want CI to fail fast so they can exit more quick.

For example:

> cargo test --help
    --no-fail-fast              Run all tests regardless of failure

@xudong963
Copy link
Member Author

Please add an args for this. We want CI to fail fast so they can exit more quick.

For example:

> cargo test --help
    --no-fail-fast              Run all tests regardless of failure

Make sense. cc @zhang2014 @sundy-li Any thoughts?

@Xuanwo
Copy link
Member

Xuanwo commented Dec 28, 2022

We can change the workflow files if we have special needs during refactor. And change it back before merging.

@sundy-li
Copy link
Member

We want CI to fail fast so they can exit more quickly.
Ok in online ci.

In local dev, we can pass this arg to have all errors.

@Xuanwo Xuanwo changed the title feat: run all sqllogictests, even if there are test failures in between feat(sqllogictests): Add no-fail-fast support Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants