Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): use ctx to store the function evaluation error #9501

Merged
merged 15 commits into from
Jan 9, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 7, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. use ctx to store the function evaluation error
  2. improve to_string from numbers using lexical_core

Closes #issue

@vercel
Copy link

vercel bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 9, 2023 at 8:56AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 7, 2023
@sundy-li sundy-li marked this pull request as ready for review January 8, 2023 05:12
src/query/functions/src/scalars/arithmetic.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/arithmetic.rs Outdated Show resolved Hide resolved
src/query/codegen/src/writes/register.rs Outdated Show resolved Hide resolved
@sundy-li sundy-li merged commit 03e380a into datafuselabs:main Jan 9, 2023
@sundy-li sundy-li deleted the expression-reg branch January 9, 2023 09:10
@sundy-li sundy-li mentioned this pull request Jan 9, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants