Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(planner): apply constant folder at physical plan builder #9889

Merged
merged 20 commits into from
Feb 20, 2023
Merged

refactor(planner): apply constant folder at physical plan builder #9889

merged 20 commits into from
Feb 20, 2023

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Feb 3, 2023 •
edited by sundy-li
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • constant fold all expressions at PhysicalPlanBuilder
  • rewrite all filter expr to is_true(try_to_boolean(<expr>)) and remove all value.as_non_null_boolean() on evaluation.
  • pushdown's filter is changed from Vec<Expr> to Option<Expr>

@vercel
Copy link

vercel bot commented Feb 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2023 at 1:46AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 3, 2023
@andylokandy andylokandy marked this pull request as draft February 5, 2023 18:30
@sundy-li sundy-li marked this pull request as ready for review February 18, 2023 15:49
@sundy-li sundy-li added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 19, 2023
@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/9889/4216510414.html

@BohuTANG
Copy link
Member

Conflicting files
src/query/storages/fuse/src/operations/read/native_data_source_deserializer.rs

@sundy-li sundy-li merged commit 2540533 into datafuselabs:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylokandy @BohuTANG @sundy-li