Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:if there may be more logs to replicate, continue to call sen… #53

Merged
merged 5 commits into from
Jan 4, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Jan 4, 2022

fix:if there may be more logs to replicate, continue to call send_append_entries in next loop, no need to wait heartbeat tick.

otherwise, replicate will be hang until next heart beat.

…d_append_entries in next loop, no need to wait heartbeat tick
@ariesdevil
Copy link
Contributor

IMO, it's a bit strange to think of more logs as an error.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

openraft/src/replication/mod.rs Outdated Show resolved Hide resolved
@drmingdrmer
Copy link
Member

BTW, as this patch is more like a bug fix, it's recommended to make the commit message like fix: blabla.
A fix: is much more important than a refactor: and deserve a seat in the change-log for next release.

…d_append_entries in next loop, no need to wait heartbeat tick
@lichuang lichuang changed the title refactor:if there may be more logs to replicate, continue to call sen… fix:if there may be more logs to replicate, continue to call sen… Jan 4, 2022
…end_entries in next loop, no need to wait heartbeat tick
…end_entries in next loop, no need to wait heartbeat tick
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants