-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:if there may be more logs to replicate, continue to call sen… #53
Conversation
…d_append_entries in next loop, no need to wait heartbeat tick
IMO, it's a bit strange to think of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
BTW, as this patch is more like a bug fix, it's recommended to make the commit message like |
…d_append_entries in next loop, no need to wait heartbeat tick
…end_entries in next loop, no need to wait heartbeat tick
…end_entries in next loop, no need to wait heartbeat tick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
fix:if there may be more logs to replicate, continue to call send_append_entries in next loop, no need to wait heartbeat tick.
otherwise, replicate will be hang until next heart beat.