Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#62]Make first_known_log_id default impl #65

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

GrapeBaBa
Copy link
Contributor

@GrapeBaBa GrapeBaBa commented Jan 5, 2022

Signed-off-by: grapebaba 281165273@qq.com

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).
  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will :).

Signed-off-by: grapebaba <281165273@qq.com>
@GrapeBaBa
Copy link
Contributor Author

@drmingdrmer how to update change log?

@GrapeBaBa GrapeBaBa changed the title Make first_known_log_id default impl [#62]Make first_known_log_id default impl Jan 5, 2022
@drmingdrmer
Copy link
Member

@drmingdrmer how to update change log?

@GrapeBaBa
There is a script ./scripts/build_change_log.py <new_tag> <commit_hash> to do this job.

Change log is only built when creating a new tag for release.
Personally, I prefer tracking changes with git commit-message. :DDD

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot!

@mergify mergify bot merged commit 0552ffb into datafuselabs:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants