Add pagination to explore

.circleci/config.yml

@@ -151,6 +151,38 @@ jobs:
           paths:
             - udata_front/theme/gouvfr/static
 
+  plugin_helper:
+    docker:
+      - image: cimg/node:lts
+    steps:
+      - checkout
+      - run:
+          name: Compute JS dependencies key
+          command: cat udata-front-plugins-helper/package.json > helper-js.deps
+      - run:
+          name: Get the base reference branch
+          command: export BASE_BRANCH=$(base_branch)
+      - restore_cache:
+          keys:
+            - js-cache-{{ arch }}-{{ checksum "helper-js.deps" }}
+            - js-cache-{{ arch }}-{{ .Branch }}
+            - js-cache-{{ arch }}-{{ .Environment.BASE_BRANCH }}
+      - run:
+          name: Install NodeJS and dependencies
+          command: npm install
+          working_directory: ./udata-front-plugins-helper
+      - save_cache:
+          key: js-cache-{{ arch }}-{{ checksum "helper-js.deps" }}
+          paths:
+          - udata-front-plugins-helper/node_modules
+      - save_cache:
+          key: js-cache-{{ arch }}-{{ .Branch }}
+          paths:
+          - udata-front-plugins-helper/node_modules
+      - run:
+          name: Compile and test package
+          working_directory: ./udata-front-plugins-helper
+          command: npm run preversion
 
   lighthouse:
     docker:
@@ -245,6 +277,10 @@ workflows:
           filters:
             tags:
               only: /v[0-9]+(\.[0-9]+)*/
+      - plugin_helper:
+          filters:
+            tags:
+              only: /v[0-9]+(\.[0-9]+)*/
       - lighthouse:
           requires:
             - deps

.gitignore

@@ -31,6 +31,8 @@ bower
 .DS_Store
 *.min.css
 *.min.js
+*.d.ts
+*.d.ts.map
 /instance/
 /static/
 node_modules
@@ -47,6 +49,7 @@ pip-log.txt
 cover
 nosetests.xml
 /reports
+/*/coverage
 
 # Translations
 *.mo

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## Current (in progress)
 
-- Nothing yet
+- Move Pagination to `@etalab/udata-front-plugin-helpers` and add tests [#200](https://github.com/etalab/udata-front/pull/200)
 
 ## 3.1.1 (2023-01-20)
 

package.json

@@ -35,7 +35,7 @@
   },
   "devDependencies": {
     "@conciergerie.dev/select-a11y": "^3.1.0",
-    "@etalab/udata-front-plugins-helper": "1.0.1",
+    "@etalab/udata-front-plugins-helper": "1.0.2-7",
     "@gouvfr/dsfr": "^1.5.1",
     "@intlify/unplugin-vue-i18n": "^0.8.0",
     "@lhci/cli": "^0.8.2",

theme/js/components/dataset/resource/resources.vue

@@ -37,7 +37,7 @@
 import {useI18n} from 'vue-i18n'
 import {onMounted, ref, watch, defineComponent} from 'vue';
 import Loader from "../loader.vue";
-import Pagination from "../../pagination/pagination.vue";
+import { Pagination } from "@etalab/udata-front-plugins-helper";
 import Resource from "./resource.vue";
 import config from "../../../config";
 import {useToast} from "../../../composables/useToast";

theme/js/components/discussions/threads.vue

@@ -96,7 +96,7 @@ import {defineComponent} from "vue";
 import config from "../../config";
 import i18n from "../../plugins/i18n";
 
-import Pagination from "../pagination/pagination.vue";
+import { Pagination } from "@etalab/udata-front-plugins-helper";
 import CreateThread from "./threads-create.vue";
 import Thread from "./thread.vue";
 import Loader from "./loader.vue";

theme/js/components/search/search.vue

@@ -176,7 +176,7 @@ import Dataset from "../dataset/search-result.vue";
 import Loader from "../dataset/loader.vue";
 import SchemaFilter from "./schema-filter.vue";
 import Empty from "./empty.vue";
-import Pagination from "../pagination/pagination.vue";
+import { Pagination } from "@etalab/udata-front-plugins-helper";
 import MultiSelect from "./multi-select.vue";
 import { search_autocomplete_debounce } from "../../config";
 import { debounce } from "../../composables/useDebouncedRef";