Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extract missing values (to data) #124

Merged
merged 5 commits into from
May 20, 2020

Conversation

roll
Copy link
Contributor

@roll roll commented Feb 18, 2020

@coveralls
Copy link

coveralls commented Feb 18, 2020

Pull Request Test Coverage Report for Build 434

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.251%

Totals Coverage Status
Change from base Build 430: 0.2%
Covered Lines: 1734
Relevant Lines: 2034

💛 - Coveralls

@roll roll changed the title [WIP] Extract missing values [WIP] Extract missing values (to data) Feb 27, 2020
@akariv
Copy link
Member

akariv commented Apr 6, 2020

Looks good @roll - do you want to merge this?

@roll
Copy link
Contributor Author

roll commented Apr 7, 2020

Hey @akariv,

Sorry I've forgotten about these two Pull Requests:

Both solutions were not good enough for BCO-DMO (still not flexible as it's needed and hard to manage with a list of arbitrary processors). So we decided to go with a global env var for tableschema-py.

If it doesn't feel like a clear improvement for dataflows in general I would close both unmerged

@akariv akariv merged commit dff6a37 into datahq:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to preserve missingValues in dump
3 participants