[WIP] Extract missing values (to metadata) #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roll
commented
Feb 27, 2020
roll
commented
- fixes Ability to preserve missingValues in dump frictionlessdata/datapackage-pipelines#177
Pull Request Test Coverage Report for Build 441
💛 - Coveralls |
akariv
requested changes
Apr 6, 2020
| missing_values = schema.get('missingValues', []) | ||
| if not self.extract_missing_values['values']: | ||
| self.extract_missing_values['values'] = missing_values | ||
| for field in schema.get('fields', []): |
There was a problem hiding this comment.
Why are you changing the schema?
It's not explained in the README
| target = self.extract_missing_values['target'] | ||
| values = self.extract_missing_values['values'] | ||
| fieldMap = {} | ||
| for resource in self.dp.descriptor['resources']: |
There was a problem hiding this comment.
why this loop?
can't you change descriptor directly?
| values = self.extract_missing_values['values'] | ||
| fieldMap = {} | ||
| for resource in self.dp.descriptor['resources']: | ||
| if resource.get('name', 'res') == descriptor.get('name', 'des'): |
| if source and key not in source: | ||
| continue | ||
| if value in values: | ||
| fieldMap[key][target][row_number] = value |
There was a problem hiding this comment.
So the empty values go in the schema??
This really contradict the documentation and makes very little sense to me...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.