feat(ui): Add new loading pattern logo #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this one. |
jjoyce0510
reviewed
Mar 11, 2022
| <rect width="34" height="68" x="56" y="56" fill="black" /> | ||
| <circle cx="90" cy="60" r="4" fill="white" /> | ||
| <circle cx="90" cy="120" r="4" fill="white" /> | ||
| <circle r="34" fill="white" /> |
There was a problem hiding this comment.
This one is my favorite :)
There was a problem hiding this comment.
How about making a watch with a red arc for the second hand, a yellow arc for the minute hand, and a blue arc for the hour hand? ⌚
DataHub logo would point to 1:40. 😄
jjoyce0510
reviewed
Mar 11, 2022
| @@ -0,0 +1,58 @@ | |||
| <svg id="datahub-logo-color_loading_panic" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" | |||
There was a problem hiding this comment.
Also really like this one!!!
jjoyce0510
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
These are amazing. Great contribution @eburairu!
Thank you on behalf of the core team 😄
eburairu
commented
Mar 11, 2022
jjoyce0510
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New loading pattern logo and fixed logo added. 👨🎨
Checklist