Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redshift) Properly handling database alias in redshift usage and redshift lineage generation #4473

Merged
merged 2 commits into from
Mar 23, 2022
Merged

fix(redshift) Properly handling database alias in redshift usage and redshift lineage generation #4473

merged 2 commits into from
Mar 23, 2022

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

treff7es
treff7es commented Mar 23, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/usage/redshift_usage.py
@@ -58,6 +58,7 @@
JOIN svl_user_info sui ON sq.userid = sui.usesysid
WHERE ss.starttime >= '{start_time}'
AND ss.starttime < '{end_time}'
AND sti.database = '{database}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to make sure we only get usage for the database set in the config

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   15m 36s ⏱️ -10s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit e42c81c. ± Comparison against base commit 4476356.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   48m 37s ⏱️
   365 tests    365 ✔️   0 💤 0 ❌
1 672 runs  1 641 ✔️ 31 💤 0 ❌

Results for commit e42c81c.

gabe-lyons
gabe-lyons reviewed Mar 23, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/sql/redshift.py
@@ -915,7 +916,8 @@ def get_lineage_mcp(
if dataset_key is None:
return None, None

if not self._lineage_map:
if self._lineage_map is None:
logger.debug("Populating lineage")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@treff7es treff7es merged commit 5c80177 into datahub-project:master Mar 23, 2022
@treff7es treff7es deleted the redshift_usage_alias branch March 23, 2022 15:01
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es @maggiehays
fix(redshift) Properly handling database alias in redshift usage and …
09198a6 
…redshift lineage generation (datahub-project#4473)

* Fix database-alias in redshift usage and redshift lineage generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @gabe-lyons