Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ui): Allow custom distBaseUrl #4542

Merged
merged 2 commits into from
Mar 31, 2022
Merged

build(ui): Allow custom distBaseUrl #4542

merged 2 commits into from
Mar 31, 2022

Conversation

mattmatravers
Copy link
Contributor

I may be able to add a section to https://github.com/datahub-project/datahub/blob/master/docs/developers.md to describe the build process behind a corporate firewall, once I have a successfully working build.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   21m 54s ⏱️ + 5m 38s
686 tests ±0  627 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 25a7100. ± Comparison against base commit a10a4ac.

shirshanka
shirshanka approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We've definitely heard about this being a problem.

@shirshanka shirshanka merged commit ee0c931 into datahub-project:master Mar 31, 2022
@mattmatravers mattmatravers deleted the patch-1 branch March 31, 2022 22:25
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mattmatravers @maggiehays
build(ui): allow custom nodeDistBaseUrl (datahub-project#4542)
d3bbfdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmatravers @shirshanka