Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vulnerability): Upgrade spring libraries to latest version #4698

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

Upgrade spring libraries to latest version to solve security vulnerabilities.
Note, they were not actually impacting our service since we use JDK8, but for future proofing.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@@ -1,3 +1,6 @@
server.port=9091
management.endpoints.web.exposure.include=metrics, health, info
spring.mvc.servlet.path=/
management.health.elasticsearch.enabled=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to add since in the latest version, spring checks dependent components, and neo4j status returns DOWN when not being used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passing LGTM.

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   19m 41s ⏱️ - 6m 45s
689 tests ±0  630 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 796d670. ± Comparison against base commit bc259af.

@dexter-mh-lee dexter-mh-lee merged commit b8cdc7e into datahub-project:master Apr 19, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--upgrade-spring branch April 19, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants