Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react theming): stop homepage flicker for env-var based logos #4730

Merged
merged 1 commit into from Apr 25, 2022
Merged

feat(react theming): stop homepage flicker for env-var based logos #4730

merged 1 commit into from Apr 25, 2022

Conversation

gabe-lyons
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   14m 45s ⏱️ - 7m 34s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 5a43bfa. ± Comparison against base commit 7bcc2d9.

@gabe-lyons gabe-lyons merged commit 28240bb into datahub-project:master Apr 25, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@gabe-lyons @maggiehays
stop homepage flicker (datahub-project#4730)
e9e02bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees

@dexter-mh-lee dexter-mh-lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabe-lyons @dexter-mh-lee