fix(policies): Remove exception on ingest policies #5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro93
reviewed
May 31, 2022
| @@ -128,7 +128,8 @@ private void updatePolicyIndex() throws URISyntaxException { | |||
| private void insertPolicyDocument(EntityResponse entityResponse, AspectSpec aspectSpec) { | |||
| EnvelopedAspect aspect = entityResponse.getAspects().get(Constants.DATAHUB_POLICY_INFO_ASPECT_NAME); | |||
| if (aspect == null) { | |||
| throw new RuntimeException(String.format("Missing policy info aspect for urn %s", entityResponse.getUrn())); | |||
| log.info("Missing policy info aspect for urn {}", entityResponse.getUrn()); | |||
There was a problem hiding this comment.
What is the impact of not throwing the runtime exception? Could GMS crash later on? Why do we even get this exception in the first place?
Finally, shouldn't this be an error or warn level log at least?
There was a problem hiding this comment.
It is because of a time delay between what happens before this and after this. There is no impact
gabe-lyons
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist