feat(bootstrap): add bootstrap step to clear out unknown aspect rows from the database #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the database
dexter-mh-lee
suggested changes
Jun 10, 2022
jjoyce0510
reviewed
Jun 13, 2022
metadata-service/factories/src/main/java/com/linkedin/metadata/boot/BootstrapManager.java
Show resolved
Hide resolved
jjoyce0510
reviewed
Jun 13, 2022
...rvice/factories/src/main/java/com/linkedin/metadata/boot/steps/RemoveUnknownAspectsStep.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Jun 13, 2022
...rc/main/java/com/linkedin/datahub/upgrade/removeunknownaspects/RemoveUnknownAspectsStep.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/entity/EntityService.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/entity/EntityService.java
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/entity/cassandra/CassandraAspectDao.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/entity/ebean/EbeanAspectDao.java
Show resolved
Hide resolved
dexter-mh-lee
approved these changes
Jun 13, 2022
jjoyce0510
reviewed
Jun 21, 2022
| public class EntityAspectIdentifier { | ||
| @Nonnull String urn; | ||
| @Nonnull String aspect; | ||
| long version; | ||
|
|
||
| public static EntityAspectIdentifier fromEbean(EbeanAspectV2 ebeanAspectV2) { |
There was a problem hiding this comment.
I really dislike the naming inconsistency of EbeanAspectV2 and CassandraAspect :( Seems very strange that this class needs to know about specific DB implementations, also.
There was a problem hiding this comment.
It's a utility conversion from the lower level aspect, made more sense here to me tied to the actual higher level object it will always be used with than in a separate utility class that will never be found by others trying to do the same thing.
jjoyce0510
reviewed
Jun 21, 2022
| // Validate pre-conditions before running queries | ||
| Urn entityUrn; | ||
| EntitySpec entitySpec; | ||
| try { | ||
| entityUrn = Urn.createFromString(urn); | ||
| String entityName = PegasusUtils.urnToEntityName(entityUrn); | ||
| entitySpec = getEntityRegistry().getEntitySpec(entityName); | ||
| Preconditions.checkState(entitySpec != null, String.format("Could not find entity definition for %s", entityName)); |
There was a problem hiding this comment.
One of them doesn't actually do anything since it will never be triggered and the other one prevents the delete from going through.
There was a problem hiding this comment.
Why would it prevent the delete?
There was a problem hiding this comment.
Don't we always populate the "aspectName" field?
jjoyce0510
reviewed
Jun 21, 2022
...rvice/factories/src/main/java/com/linkedin/metadata/boot/steps/RemoveUnknownAspectsStep.java
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Jun 21, 2022
...rc/main/java/com/linkedin/datahub/upgrade/removeunknownaspects/RemoveUnknownAspectsStep.java
Outdated
Show resolved
Hide resolved
jjoyce0510
approved these changes
Jun 21, 2022
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Jun 22, 2022
alexey-kravtsov
pushed a commit
to infobip/datahub
that referenced
this pull request
Jul 8, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist