Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(restore-indices): Do not fail on MAE row count diff #5165

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix(restore-indices): Do not fail on MAE row count diff #5165

merged 1 commit into from
Jun 14, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

A few rows may fail to get restored (i.e. compatibility issues, deprecated aspects, etc.)
Do not mark job as failed even if some rows fail to get restored.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

381 tests   381 ✔️  2m 49s ⏱️
  89 suites      0 💤
  89 files        0 ❌

Results for commit a5cb2ab.

jjoyce0510
jjoyce0510 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we at least know what didn't get restored?

This seems a bit dangerous with respect to reliability.

@dexter-mh-lee
Copy link
Contributor Author

We already print error messages when anything fails, so should be okay.

@dexter-mh-lee dexter-mh-lee merged commit b890ba0 into datahub-project:master Jun 14, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(restore-indices): Do not fail on MAE row count diff (datahub-proj…
327a9b5 
…ect#5165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter-mh-lee @jjoyce0510