Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs-website): make codegen script idempotent #5620

Merged
merged 3 commits into from
Aug 15, 2022
Merged

build(docs-website): make codegen script idempotent #5620

merged 3 commits into from
Aug 15, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 11, 2022 •
edited
Loading

Bonus:

  • Correctly handle untracked / deleted files with git
  • Rename gradle command yarnServe -> yarnStart
  • Correct info in docs-website readme

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

hsheth2 added a commit to hsheth2/datahub that referenced this pull request Aug 11, 2022
@hsheth2
build(docs-website): only show release notes for recent releases
37718d4 
Bonus: also hides the release candidates from the docs website and
tweaks our date formatting to look better.

Changes stacked on top of
datahub-project#5620, so merge that
first.
@hsheth2 hsheth2 mentioned this pull request Aug 11, 2022
Merged
@github-actions
Copy link

Unit Test Results (build & test)

499 tests  ±0   499 ✔️ ±0   8m 26s ⏱️ -16s
115 suites ±0       0 💤 ±0 
115 files   ±0       0 ❌ ±0 

Results for commit 3f245b0. ± Comparison against base commit e9494f5.

hsheth2 added a commit to hsheth2/datahub that referenced this pull request Aug 11, 2022
@hsheth2
build(docs-website): only show release notes for recent releases
821c862 
Bonus: also hides the release candidates from the docs website and
tweaks our date formatting to look better.

Changes stacked on top of
datahub-project#5620, so merge that
first.
hsheth2 added a commit that referenced this pull request Aug 11, 2022
@hsheth2
build(docs-website): only show release notes for recent releases (#5621
bfa28b6 
)

* build(docs-website): only show release notes for recent releases

Bonus: also hides the release candidates from the docs website and
tweaks our date formatting to look better.

Changes stacked on top of
#5620, so merge that
first.

* lint
@maggiehays maggiehays added the ingestion PR or Issue related to the ingestion of metadata label Aug 12, 2022
@hsheth2 hsheth2 added docs Issues and Improvements to docs and removed ingestion PR or Issue related to the ingestion of metadata labels Aug 12, 2022
shirshanka
shirshanka approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 245ea89 into datahub-project:master Aug 15, 2022
@hsheth2 hsheth2 deleted the docs-site-codegen-fix branch December 15, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons Awaiting requested review from gabe-lyons

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @maggiehays