feat(restore-indices): add multithreading and add aspectName, urn filter #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Aug 23, 2022
datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/restoreindices/SendMAEStep.java
Outdated
Show resolved
Hide resolved
shirshanka
reviewed
Aug 23, 2022
datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/restoreindices/SendMAEStep.java
Outdated
Show resolved
Hide resolved
anshbansal
changed the title
anshbansal
changed the title
jjoyce0510
reviewed
Aug 28, 2022
There was a problem hiding this comment.
Nice improvements!
I'm a bit nervous about correctness given the scope of changes - have you been able to validate the behavior of this job locally?
Going to also ask that @RyanHolstien takes a pass at this since he's been getting super familiar with this job recently :)
|
Smoke test failure has nothing to do with this change. It seems that is broken in latest master. |
anshbansal
changed the title
| int numThreads = getThreadCount(context.parsedArgs()); | ||
| long batchDelayMs = getBatchDelayMs(context.parsedArgs()); | ||
| Optional<String> aspectName; | ||
| if (containsKey(context.parsedArgs(), RestoreIndices.ASPECT_NAME_ARG_NAME)) { |
There was a problem hiding this comment.
I think we should move away from the command line arguments approach, it's less flexible than just pure ENV and requires us to modify the helm chart templates every time we add new configuration.
datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/restoreindices/SendMAEStep.java
Outdated
Show resolved
Hide resolved
RyanHolstien
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist