-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(restore-indices): add multithreading and add aspectName, urn filter #5712
Merged
RyanHolstien
merged 15 commits into
datahub-project:master
from
anshbansal:improve-logging
Aug 29, 2022
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
815717e
feat(upgrade): improve logging to get idea of progress
anshbansal b3b6f24
division by zero check
anshbansal e8a8c01
division by zero fix
anshbansal dd519ea
wip
anshbansal 14a7112
temp work
anshbansal 73bcaef
Merge remote-tracking branch 'origin' into improve-logging
anshbansal b90e923
feat(datahub-upgrade): add multi-threading and aspect filter
anshbansal 1eca8a4
revert change on local
anshbansal 2d952e5
fix bugs
anshbansal 56c9308
add back batchDelayMs
anshbansal bc68790
remove redundant format
anshbansal e0bf669
report stats finally, shutdown executor
anshbansal e1ba439
Add time metrics
anshbansal 556751d
clarify logging
anshbansal b104c3d
improve logging
anshbansal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move away from the command line arguments approach, it's less flexible than just pure ENV and requires us to modify the helm chart templates every time we add new configuration.