Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ingest): add vulture config and remove some dead code #5745

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 26, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Unit Test Results (metadata ingestion)

       8 files  +       8         8 suites  +8   59m 51s ⏱️ + 59m 51s
   655 tests +   655     652 ✔️ +   652  3 💤 +3  0 ±0 
1 310 runs  +1 310  1 304 ✔️ +1 304  6 💤 +6  0 ±0 

Results for commit 93c03d4. ± Comparison against base commit fa0fd7b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Unit Test Results (build & test)

504 tests   504 ✔️  8m 10s ⏱️
117 suites      0 💤
117 files        0

Results for commit 93c03d4.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka added the ingestion PR or Issue related to the ingestion of metadata label Aug 28, 2022
@shirshanka
Copy link
Contributor

Waiting to approve until we get confirmations from the authors (@mayurinehate , @rslanka ) that these classes are safe to remove or whether they missed adding a dependency on them.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ee43262 into datahub-project:master Aug 29, 2022
@hsheth2 hsheth2 deleted the dead-code-removal branch December 15, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants