Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): Fix oauth config validation in snowflake. #5796

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Aug 31, 2022

Fixes the oauth config validation in snowflake config.
It is causing test failures on the CI jobs recently like

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@rslanka rslanka assigned rslanka and hsheth2 and unassigned rslanka Aug 31, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 44s ⏱️ - 1m 1s
   661 tests ±0     658 ✔️ +1  3 💤 ±0  0  - 1 
1 322 runs  ±0  1 316 ✔️ +2  6 💤 ±0  0  - 2 

Results for commit d0aebf4. ± Comparison against base commit dbcd309.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ +2   8m 10s ⏱️ - 1m 36s
121 suites ±0       0 💤 ±0 
121 files   ±0       0  - 2 

Results for commit d0aebf4. ± Comparison against base commit dbcd309.

@shirshanka shirshanka merged commit af1fc8d into datahub-project:master Sep 1, 2022
@rslanka rslanka deleted the fix_snowflake_oauth_config_validation branch September 1, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants