Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): support version option in datahub client get_aspect_v2 #5934

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 14, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 14, 2022
@xiphl
Copy link
Contributor

xiphl commented Sep 14, 2022

Thanks 🙏

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 11s ⏱️ + 2m 20s
   709 tests ±0     706 ✔️ ±0  3 💤 ±0  0 ±0 
1 418 runs  ±0  1 412 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 5537de5. ± Comparison against base commit 15a33fa.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   15m 11s ⏱️ +19s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 5537de5. ± Comparison against base commit 15a33fa.

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit e3f8f29 into datahub-project:master Sep 14, 2022
@hsheth2 hsheth2 deleted the get-aspect-version branch September 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants