Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): bigquery-beta - Additional fixes for Bigquery beta #6051

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

treff7es
Copy link
Contributor

  • Apply lineage extraction enable parameter for views as well
  • Range partitioned tables are partitioned on the last partition
  • Making lineage parser exceptions less verbose to don't freak out users
  • Fixing invalid partition in report

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

- Apply lineage extraction enable parameter for views as well
- Range partitioned tables are partitioned on the last partition
- Making lineage parser exceptions less verbose to don't freak out users
- Fixing invalid partition in report
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 26, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   1h 1m 34s ⏱️ + 4m 48s
   717 tests ±0     714 ✔️ ±0  3 💤 ±0  0 ±0 
1 436 runs  ±0  1 430 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit a028d58. ± Comparison against base commit 611c053.

@github-actions
Copy link

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 48s ⏱️ -3s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit a028d58. ± Comparison against base commit 611c053.

partition_column: Optional[BigqueryColumn] = None
for column in table.columns:
if column.is_partition_column:
partition_column = column
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can there be multiple partition columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigQuery only supports partitioning on one column.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 32b8bef into datahub-project:master Sep 26, 2022
@treff7es treff7es deleted the bigquery_beta_fixes branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants