Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): allow hiding some fields from the schema #6077

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix(ingest): allow hiding some fields from the schema #6077

merged 2 commits into from
Oct 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 28, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 28, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 1m 40s ⏱️
   719 tests    716 ✔️ 3 💤 0 ❌
1 440 runs  1 434 ✔️ 6 💤 0 ❌

Results for commit 3c53505.

@github-actions
Copy link

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   12m 55s ⏱️ - 1m 3s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ❌ ±0 

Results for commit 3c53505. ± Comparison against base commit 09dec1a.

treff7es
treff7es approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsheth2 hsheth2 merged commit 0427122 into datahub-project:master Oct 11, 2022
@hsheth2 hsheth2 deleted the schema-exclude branch October 11, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es