-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest): looker - support for simple column level lineage #6084
feat(ingest): looker - support for simple column level lineage #6084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits, but neither is a show stopper so they can be done in a follow up
): | ||
(view_name, field_path) = field.upstream_field.split(".")[ | ||
0 | ||
], ".".join(field.upstream_field.split(".")[1:]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use split(maxsplit=1)
if type_cls == ViewFieldType.DIMENSION and extract_column_level_lineage: | ||
if field_dict.get("sql") is not None: | ||
upstream_field_match = re.match( | ||
r"^.*\${TABLE}\.(.*)$", field_dict["sql"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a comment explaining what this regex does
thx @hsheth2 |
Adds very simple column level lineage for looker
Table -> View
and
View -> Explore.
Checklist