fix(ingest): allow snowflake profiling to work with geography type #6162

mayurinehate · 2022-10-10T13:06:33Z

other changes-

use sqlalchemy column function for quoting as opposed to always quoting columns
ingest precise native data type for text and numeric types

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

other changes- - use sqlalchemy column function for quoting as opposed to always quoting columns - ingest precise native data type for text and numeric types

github-actions · 2022-10-10T13:29:20Z

Unit Test Results (metadata ingestion)

    7 files ±0     7 suites ±0 55m 54s ⏱️ + 7m 15s
732 tests ±0 722 ✔️ +3 2 💤 ±0 8 ❌ ±0
786 runs ±0 774 ✔️ +3 4 💤 ±0 8 ❌ ±0

For more details on these failures, see this check.

Results for commit 3a07252. ± Comparison against base commit e9f6154.

github-actions · 2022-10-10T13:39:28Z

Unit Test Results (build & test)

597 tests ±0 593 ✔️ ±0 11m 56s ⏱️ +17s
147 suites ±0     4 💤 ±0
147 files ±0     0 ❌ ±0

Results for commit 3a07252. ± Comparison against base commit e9f6154.

shirshanka

LGTM

fix(ingest): allow snowflake profiling to work with geography type

3a07252

other changes- - use sqlalchemy column function for quoting as opposed to always quoting columns - ingest precise native data type for text and numeric types

github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 10, 2022

mayurinehate requested a review from hsheth2 October 10, 2022 13:14

shirshanka approved these changes Oct 10, 2022

View reviewed changes

shirshanka added 2 commits October 10, 2022 07:40

fix snowflake goldens

b5504d8

fix up bigquery tests

d54324a

shirshanka merged commit 7b88de8 into datahub-project:master Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ingest): allow snowflake profiling to work with geography type #6162

fix(ingest): allow snowflake profiling to work with geography type #6162

mayurinehate commented Oct 10, 2022

github-actions bot commented Oct 10, 2022

github-actions bot commented Oct 10, 2022

shirshanka left a comment

fix(ingest): allow snowflake profiling to work with geography type #6162

fix(ingest): allow snowflake profiling to work with geography type #6162

Conversation

mayurinehate commented Oct 10, 2022

Checklist

github-actions bot commented Oct 10, 2022

Unit Test Results (metadata ingestion)

github-actions bot commented Oct 10, 2022

Unit Test Results (build & test)

shirshanka left a comment

Choose a reason for hiding this comment