Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/mssql): add type mappings for BIT and SQL_VARIANT #6304

Merged
merged 1 commit into from Oct 28, 2022
Merged

feat(ingest/mssql): add type mappings for BIT and SQL_VARIANT #6304

merged 1 commit into from Oct 28, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 27, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 27, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   56m 38s ⏱️
   748 tests    745 ✔️ 3 💤 0 ❌
1 498 runs  1 492 ✔️ 6 💤 0 ❌

Results for commit 7d594a3.

@github-actions
Copy link

Unit Test Results (build & test)

599 tests  ±0   595 ✔️ ±0   11m 45s ⏱️ +5s
149 suites ±0       4 💤 ±0 
149 files   ±0       0 ❌ ±0 

Results for commit 7d594a3. ± Comparison against base commit 7b2a76d.

treff7es
treff7es approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 5b4f5f8 into datahub-project:master Oct 28, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
@hsheth2
feat(ingest): mssql - add type mappings for BIT and SQL_VARIANT (data…
662d989 
…hub-project#6304)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): mssql - add type mappings for BIT and SQL_VARIANT (data…
9b64ac6 
…hub-project#6304)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest): mssql - add type mappings for BIT and SQL_VARIANT (data…
19a4937 
…hub-project#6304)
@hsheth2 hsheth2 deleted the mssql-types branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @treff7es