Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/mssql): add type mappings for BIT and SQL_VARIANT #6304

Merged
merged 1 commit into from Oct 28, 2022
Merged

feat(ingest/mssql): add type mappings for BIT and SQL_VARIANT #6304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/sql/mssql.py
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
from typing import Any, Dict, Iterable, List, Optional, Tuple

import pydantic
import sqlalchemy.dialects.mssql

# This import verifies that the dependencies are available.
import sqlalchemy_pytds # noqa: F401
Expand All @@ -26,10 +27,15 @@
BasicSQLAlchemyConfig,
SQLAlchemySource,
make_sqlalchemy_uri,
register_custom_type,
)
from datahub.metadata.schema_classes import BooleanTypeClass, UnionTypeClass

logger: logging.Logger = logging.getLogger(__name__)

register_custom_type(sqlalchemy.dialects.mssql.BIT, BooleanTypeClass)
register_custom_type(sqlalchemy.dialects.mssql.SQL_VARIANT, UnionTypeClass)


class SQLServerConfig(BasicSQLAlchemyConfig):
# defaults
Expand Down