Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ingest): loosen jinja2 dependency for superset #6433

Merged
merged 5 commits into from
Nov 16, 2022
Merged

build(ingest): loosen jinja2 dependency for superset #6433

merged 5 commits into from
Nov 16, 2022

Conversation

KulykDmytro
Copy link
Contributor

closes #6388

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 14, 2022
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 14, 2022
@hsheth2 hsheth2 changed the title build: loose jinja2 dependency in Superset (#6388) build(ingest): loosen jinja2 dependency for superset Nov 16, 2022
hsheth2
hsheth2 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we might even be able to remove that dependency entirely

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 6s ⏱️ + 2m 21s
   758 tests ±0     755 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 518 runs  ±0  1 511 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit d9bd7f1. ± Comparison against base commit 1ffd241.

@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 42s ⏱️ -1s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit d9bd7f1. ± Comparison against base commit 1ffd241.

@jjoyce0510 jjoyce0510 merged commit ba7fc3a into datahub-project:master Nov 16, 2022
@KulykDmytro
Copy link
Contributor Author

@hsheth2 do you need me to PR for removal?
Is it really not using Jinja2 directly

@KulykDmytro KulykDmytro mentioned this pull request Nov 17, 2022
Merged
5 tasks
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@KulykDmytro @cccs-Dustin
deps(jinja): loose jinja2 dependency in Superset (datahub-project#6388)…
3eace53 
… (datahub-project#6433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loosen Jinja2 dependencies
4 participants
@KulykDmytro @hsheth2 @maggiehays @jjoyce0510