Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Add owner to dataset - allow same owner with a different type #6463

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

rtekal
Copy link
Contributor

@rtekal rtekal commented Nov 17, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 17, 2022
@jjoyce0510
Copy link
Collaborator

Hi @rtekal - Have you confirmed that this looks okay on the UI?

I think this is doable but we've traditionally held the stance that a single person should only hold one ownership type at a time, in order to reduce confusion around responsibility.

Can you elaborate on how this change will help benefit your org?

Thanks for the PR!
John

@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 41s ⏱️ -22s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ±0 

Results for commit 4fdacdf. ± Comparison against base commit 1fe0f01.

@rtekal
Copy link
Contributor Author

rtekal commented Nov 22, 2022

In our organization, the same individual has multiple roles. This is true for small teams. addUser mutation does not allow the same user to be added irrespective of different role. It does not violate anything. The change I submitted filters out if the same individual with the same role is added multiple times, however if the role is different, it is allowed.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jjoyce0510 jjoyce0510 merged commit 42ee2f3 into datahub-project:master Nov 29, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
datahub-project#6463)

Co-authored-by: vtekal <varadaraj_tekal@optum.com>
Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants