Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/csv-enrich): handle BOM character #6509

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat(ingest/csv-enrich): handle BOM character #6509

merged 1 commit into from
Nov 22, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 22, 2022

This has come up a number of times e.g. https://datahubspace.slack.com/archives/C029A3M079U/p1669000226732159?thread_ts=1669000226.732159&cid=C029A3M079U

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 22, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 56s ⏱️ +57s
   761 tests ±0     758 ✔️ +6  3 💤 ±0  0 ❌  - 1 
1 524 runs  ±0  1 517 ✔️ +7  7 💤 ±0  0 ❌  - 2 

Results for commit d6fc170. ± Comparison against base commit 490097e.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 51s ⏱️ +8s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit d6fc170. ± Comparison against base commit 490097e.

@hsheth2 hsheth2 merged commit 3fdaf13 into datahub-project:master Nov 22, 2022
@hsheth2 hsheth2 deleted the csv-bom branch November 22, 2022 17:53
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
feat(ingest/csv-enrich): handle BOM character (datahub-project#6509)
7a0477f 
This has come up a number of times e.g. https://datahubspace.slack.com/archives/C029A3M079U/p1669000226732159?thread_ts=1669000226.732159&cid=C029A3M079U
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @jjoyce0510