Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): restrict snowflake-connector-python dependency #6594

Merged
merged 1 commit into from
Dec 1, 2022
Merged

fix(ingest): restrict snowflake-connector-python dependency #6594

merged 1 commit into from
Dec 1, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 1, 2022
treff7es
treff7es approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 54s ⏱️ - 1m 20s
   765 tests ±0     763 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 532 runs  ±0  1 527 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 3f41e1f. ± Comparison against base commit 72b95f2.

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 57s ⏱️ +13s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 3f41e1f. ± Comparison against base commit 72b95f2.

@treff7es treff7es merged commit f63c3e5 into datahub-project:master Dec 1, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
fix(ingest): restrict snowflake-connector-python dependency (datahub-…
d7d7899 
…project#6594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @treff7es