fix(ingest): profiling - Changing profiling defaults #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Dec 5, 2022
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_profiler.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| @dataclass | ||
| class DetailedProfilerReport(SQLSourceReport): |
There was a problem hiding this comment.
in general, I want to move towards shorter inheritance hierarchies. This should be DetailedProfilerReportMixin and should not inherit from SQLSourceReport, and instead the inheriting classes should inherit from this and SQLSourceReport
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery.py
Outdated
Show resolved
Hide resolved
hsheth2
approved these changes
Dec 6, 2022
| last_altered: datetime | ||
| size_in_bytes: int | ||
| rows_count: int | ||
| columns: List[SqlTableColumn] = field(default_factory=list) |
| last_altered: datetime | ||
| comment: str | ||
| ddl: str | ||
| class BigqueryView(BaseView): |
There was a problem hiding this comment.
For 100% correctness, this can be changed and the columns field can be removed. However, it's probably good enough as-is so no need to change it
Suggested change
| class BigqueryView(BaseView): | |
| class BigqueryView(BaseView[BigqueryColumn]): |
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist