-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): reduce flakiness in add_users, siblings smoke test #6883
Changes from 1 commit
f33deed
11a72a4
3db0350
d6e07ca
890785c
bf467a4
7d6841b
c839dfc
33bc1a2
d352887
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,8 +22,9 @@ describe("add_user", () => { | |
|
||
cy.clickOptionWithText("Invite Users") | ||
|
||
cy.waitTextVisible('signup?invite_token').then(($elem) => { | ||
cy.waitTextVisible(/signup\?invite_token=\w+/).then(($elem) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sometimes the UI was loading |
||
const inviteLink = $elem.text(); | ||
cy.log(inviteLink); | ||
cy.logout(); | ||
cy.visit(inviteLink); | ||
let name = tryToSignUp(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ describe('siblings', () => { | |
cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.customers,PROD)/?is_lineage_mode=false'); | ||
|
||
// navigate to the bq entity | ||
cy.get('[data-testid="compact-entity-link-urn:li:dataset:(urn:li:dataPlatform:bigquery,cypress_project.jaffle_shop.customers,PROD)"]').click({ force: true }); | ||
cy.clickOptionWithTestId('compact-entity-link-urn:li:dataset:(urn:li:dataPlatform:bigquery,cypress_project.jaffle_shop.customers,PROD)'); | ||
|
||
// check merged platforms is not shown | ||
cy.get('[data-testid="entity-header-test-id"]').contains('dbt & BigQuery').should('not.exist'); | ||
|
@@ -62,16 +62,16 @@ describe('siblings', () => { | |
cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.customers,PROD)/?is_lineage_mode=false'); | ||
|
||
// navigate to the bq entity | ||
cy.get('[data-testid="compact-entity-link-urn:li:dataset:(urn:li:dataPlatform:bigquery,cypress_project.jaffle_shop.customers,PROD)"]').click({ force: true }); | ||
cy.clickOptionWithTestId('compact-entity-link-urn:li:dataset:(urn:li:dataPlatform:bigquery,cypress_project.jaffle_shop.customers,PROD)'); | ||
|
||
cy.contains('Add Term').click(); | ||
cy.clickOptionWithText('Add Term'); | ||
|
||
cy.selectOptionInTagTermModal('CypressTerm'); | ||
|
||
cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.customers,PROD)/?is_lineage_mode=false'); | ||
|
||
cy.get('a[href="/glossaryTerm/urn:li:glossaryTerm:CypressNode.CypressTerm"]').within(() => cy.get('span[aria-label=close]').click()); | ||
cy.contains('Yes').click(); | ||
cy.clickOptionWithText('Yes'); | ||
|
||
cy.contains('CypressTerm').should('not.exist'); | ||
}); | ||
|
@@ -88,18 +88,6 @@ describe('siblings', () => { | |
cy.get('.test-search-result-sibling-section').get('.test-mini-preview-class:contains(raw_orders)').should('have.length', 2); | ||
}); | ||
|
||
it('will combine results in search', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. deleted as this was a duplicate test as the one above it (expand the diff to see the duplicate) |
||
cy.login(); | ||
cy.visit('/search?page=1&query=%2522raw_orders%2522'); | ||
|
||
cy.contains('Showing 1 - 2 of 2 results'); | ||
|
||
cy.get('.test-search-result').should('have.length', 1); | ||
cy.get('.test-search-result-sibling-section').should('have.length', 1); | ||
|
||
cy.get('.test-search-result-sibling-section').get('.test-mini-preview-class:contains(raw_orders)').should('have.length', 2); | ||
}); | ||
|
||
it('will combine results in lineage', () => { | ||
cy.login(); | ||
cy.visit('dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.stg_orders,PROD)/?is_lineage_mode=true'); | ||
|
@@ -122,7 +110,7 @@ describe('siblings', () => { | |
cy.login(); | ||
cy.visit('dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.stg_orders,PROD)/?is_lineage_mode=true'); | ||
|
||
cy.get('[data-testid="compress-lineage-toggle"]').click({ force: true }); | ||
cy.clickOptionWithTestId('compress-lineage-toggle'); | ||
|
||
// check the subtypes | ||
cy.get('text:contains(View)').should('have.length', 2); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
:
at the end was causing error