Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bootstrap): add EDIT_LINEAGE privilege to some default policies #7060

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix(bootstrap): add EDIT_LINEAGE privilege to some default policies #7060

merged 1 commit into from
Jan 18, 2023

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Jan 17, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jan 17, 2023
chriscollins3456
chriscollins3456 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i think these are technically unnecessary since you can edit lineage with EDIT_ENTITY as well, but adding it explicitly is a good thing.

metadata-service/war/src/main/resources/boot/policies.json
Comment on lines 47 to +49
"EDIT_ENTITY",
"VIEW_ENTITY_PAGE"
"VIEW_ENTITY_PAGE",
"EDIT_LINEAGE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this isn't necessary since if you have EDIT_ENTITY you can also edit the lineage

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess that's the case for all of these...

but I'm not against being explicit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I didn't know about that. Yeah makes it clearer I guess :)

@aditya-radhakrishnan aditya-radhakrishnan merged commit 84f429c into master Jan 18, 2023
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--edit-lineage-bootstrap branch January 18, 2023 00:32
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Jan 18, 2023
@aditya-radhakrishnan @shirshanka
fix(bootstrap): add EDIT_LINEAGE privilege to some default policies (d…
9c904b0 
…atahub-project#7060)
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Jan 18, 2023
@aditya-radhakrishnan
fix(bootstrap): add EDIT_LINEAGE privilege to some default policies (d…
56f4c63 
…atahub-project#7060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aditya-radhakrishnan @chriscollins3456