Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): add EDIT_LINEAGE privilege to some default policies #7060

Merged
merged 1 commit into from
Jan 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions metadata-service/war/src/main/resources/boot/policies.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
},
"privileges":[
"EDIT_ENTITY",
"VIEW_ENTITY_PAGE"
"VIEW_ENTITY_PAGE",
"EDIT_LINEAGE"
Comment on lines 47 to +49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this isn't necessary since if you have EDIT_ENTITY you can also edit the lineage

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess that's the case for all of these...

but I'm not against being explicit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I didn't know about that. Yeah makes it clearer I guess :)

],
"displayName":"Root User - Edit and View All Resources",
"description":"Grants full edit and view privileges for all resources to root 'datahub' root user.",
Expand Down Expand Up @@ -216,7 +217,8 @@
"MANAGE_ENTITY_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_TAGS_PRIVILEGE",
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE"
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE",
"EDIT_LINEAGE"

],
"displayName":"Admins - Metadata Policy",
Expand Down Expand Up @@ -290,7 +292,8 @@
"MANAGE_ENTITY_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_TAGS_PRIVILEGE",
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE"
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE",
"EDIT_LINEAGE"
],
"displayName":"Editors - Metadata Policy",
"description":"Editors have all metadata privileges.",
Expand Down Expand Up @@ -380,7 +383,8 @@
"MANAGE_ENTITY_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_GLOSSARY_TERMS_PRIVILEGE",
"MANAGE_DATASET_COL_TAGS_PRIVILEGE",
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE"
"EDIT_ENTITY_ASSERTIONS_PRIVILEGE",
"EDIT_LINEAGE"
],
"displayName":"Asset Owners - Metadata Policy",
"description":"Asset Owners have all metadata privileges ONLY for assets they own.",
Expand Down