Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/delete): skip references prompt if deleting an aspect #7220

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix(cli/delete): skip references prompt if deleting an aspect #7220

merged 1 commit into from
Feb 2, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 2, 2023

If you're trying to delete a single aspect, we shouldn't ask you to delete all references to the entire entity.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 2, 2023
jjoyce0510
jjoyce0510 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jjoyce0510 jjoyce0510 merged commit 23730e0 into datahub-project:master Feb 2, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2
fix(cli/delete): skip references prompt if deleting an aspect (datahu…
dcdea53 
…b-project#7220)
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@hsheth2
fix(cli/delete): skip references prompt if deleting an aspect (datahu…
8c3bfe8 
…b-project#7220)
@hsheth2 hsheth2 deleted the delete-aspect branch February 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @jjoyce0510