New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend logs): Silencing harmless log messages (and adding path for future) #7254
Merged
anshbansal
merged 1 commit into
datahub-project:master
from
jjoyce0510:jj--hush-pac4j-session-renewal
Feb 6, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package log; | ||
|
||
import ch.qos.logback.classic.spi.ILoggingEvent; | ||
import ch.qos.logback.core.filter.AbstractMatcherFilter; | ||
import ch.qos.logback.core.spi.FilterReply; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
|
||
/** | ||
* A Log Filter that can be configured to omit logs containing a specific message string. | ||
* Configured inside logback.xml. | ||
*/ | ||
public class LogMessageFilter extends AbstractMatcherFilter<ILoggingEvent> { | ||
|
||
/** | ||
* A set of messages to exclude. | ||
*/ | ||
private final List<String> excluded = new ArrayList<>(); | ||
|
||
@Override | ||
public FilterReply decide(ILoggingEvent event) { | ||
if (!isStarted()) { | ||
return FilterReply.NEUTRAL; | ||
} | ||
|
||
if (this.excluded.stream().anyMatch(message -> event.getFormattedMessage().contains(message))) { | ||
return FilterReply.DENY; | ||
} | ||
return FilterReply.ACCEPT; | ||
} | ||
|
||
public void addExcluded(String message) { | ||
this.excluded.add(message); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,10 @@ | |
<filter class="ch.qos.logback.classic.filter.ThresholdFilter"> | ||
<level>INFO</level> | ||
</filter> | ||
<filter class="log.LogMessageFilter"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. woah this is super cool |
||
<excluded>Unable to renew the session. The session store may not support this feature</excluded> | ||
<excluded>Preferred JWS algorithm: null not available. Using all metadata algorithms:</excluded> | ||
</filter> | ||
</appender> | ||
|
||
<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender"> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice so the
<excluded>
tag in the xml file just automatically fills this out?