Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) Update styles of embedded profile page to match designs #7348

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix(ui) Update styles of embedded profile page to match designs #7348

merged 2 commits into from
Feb 15, 2023

Conversation

chriscollins3456
Copy link
Collaborator

Makes two changes:

  1. Make color configurable for entity icons using the entity registry. Then pass in a darker gray on the embedded profile to match the color of the entity type next to it.
  2. Update the copy and icon for upstream health when we don't have any upstream data quality inputs.

Here's the new upstream health look:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 15, 2023
jjoyce0510
jjoyce0510 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI is green LGTM.

@chriscollins3456 chriscollins3456 merged commit 979265d into datahub-project:master Feb 15, 2023
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@chriscollins3456
fix(ui) Update styles of embedded profile page to match designs (data…
11c885e 
…hub-project#7348)
yoonhyejin pushed a commit that referenced this pull request Mar 3, 2023
@chriscollins3456
fix(ui) Update styles of embedded profile page to match designs (#7348)
f71f075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@aditya-radhakrishnan aditya-radhakrishnan Awaiting requested review from aditya-radhakrishnan

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscollins3456 @jjoyce0510