Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(): add sources summary page #7480

Merged
merged 52 commits into from
Mar 10, 2023

Conversation

laulpogan
Copy link
Contributor

@laulpogan laulpogan commented Mar 2, 2023

Checklist

This is an integrations page for the DH docs. See it live here: https://laulpogan.github.io/datahubSitePreview/integrations/

Nice to haves:
Pull metadata from docusaurus json files / tag pages etc with frontmatter like tags
Review tags for quality.

import useGlobalData from "@docusaurus/useGlobalData";
import DropDownFilter from "./_components/DropDownFilter";

const metadata = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put this in JSON and then import it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will put into a son file

@laulpogan
Copy link
Contributor Author

laulpogan commented Mar 8, 2023

It'd be great to update this page https://datahubproject.io/docs/cli/#sources

Will take a look

Could you also put a screenshot of the page in the PR description to give us an idea of what it looks like?

https://laulpogan.github.io/datahubSitePreview/integrations/ do ya one better! This is slightly laggin since it needs to be pushed to, but it's a live version to play with

I don't really understand all the jsx/css, but it seems like a lot of stuff. I also saw some algolia things that didn't seem fully related to this change?

The component is initally copied from the search bar component, so we can chop out the irrelevant styles- it didn't feel particularly relevant, but happy to do it

@laulpogan
Copy link
Contributor Author

@hsheth2 all requested changes made!

@laulpogan laulpogan requested a review from hsheth2 March 9, 2023 17:44
docs-website/package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laulpogan laulpogan merged commit c4d1d82 into datahub-project:master Mar 10, 2023
laulpogan added a commit that referenced this pull request Mar 10, 2023
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 11, 2023
Co-authored-by: Jeff Merrick <jeff@wireform.io>
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 11, 2023
Co-authored-by: Jeff Merrick <jeff@wireform.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants