refactor(ui): Fix scrolling behavior for compact entity profile #7599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Mar 15, 2023
| @@ -73,6 +73,10 @@ type Props<T, U> = { | |||
| isNameEditable?: boolean; | |||
| }; | |||
|
|
|||
| const MAX_SIDEBAR_WIDTH = 800; | |||
| const MIN_SIDEBAR_WIDTH = 200; | |||
| const MAX_COMPACT_WIDTH = 490 - 24 * 2; | |||
There was a problem hiding this comment.
where does this number come from?
There was a problem hiding this comment.
we give the slide out modal a max width of 490 elsewhere :/
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, there was horizontal scroll in the compact entity profile shown in lineage when there were long browse paths or other content. This PR fixes it by getting rid of horizontal scroll.
Status
Ready for review
Screenshots
Before ->
After ->
Checklist