Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revert): remove unnecessary class check #7658

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

RyanHolstien
Copy link
Collaborator

A PR went in for support of diffMode for Neo4J, the class check is no longer necessary although could cause an issue if someone is using DGraph.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

A PR went in for support of diffMode for Neo4J, the class check is no longer necessary although could cause an issue if someone is using DGraph.
@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 4:14PM (UTC)

Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@david-leifker david-leifker merged commit 8963e53 into master Mar 21, 2023
@david-leifker david-leifker deleted the RyanHolstien-patch-2 branch March 21, 2023 17:53
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants