Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): refactor guide on graphql #7745

Merged
merged 8 commits into from
Apr 7, 2023
Merged

feat(docs): refactor guide on graphql #7745

merged 8 commits into from
Apr 7, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Apr 3, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

resolves DR-359

Demo

https://docs-website-7dtkfrh4q-acryldata.vercel.app/docs/api/graphql/how-to-set-up-graphql

@yoonhyejin yoonhyejin mentioned this pull request Apr 3, 2023
Closed
5 tasks
@github-actions github-actions bot added docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata labels Apr 3, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 4, 2023

@yoonhyejin for the SDK section, I'm adding this PR to make it easier via python #7753

gabe-lyons
gabe-lyons approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping to unblock, would be good to address Harshal's syntax highlighting before merging

@yoonhyejin yoonhyejin merged commit 294c5ff into master Apr 7, 2023
@yoonhyejin yoonhyejin deleted the docs/graphql-guide branch April 7, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

@laulpogan laulpogan Awaiting requested review from laulpogan

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoonhyejin @hsheth2 @gabe-lyons @acryl-hyejin