fix(ui): Fix tags display name + color in UI for autocomplete, search preview, entity profile #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get this removed
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 19, 2023
… preview, entity profile (#7785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we were using the urn-derived "name" field in some cases to render the name of a Tag. In this PR, we change to use the correct "name" field of the properties aspect, which can be changed once the Tag has been created.
This fixes a few different scenarios:
Status
Ready for review
Screenshots
Before (notice the URN derived name):
(Fixed color in autocomplete)
Checklist