Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Fix tags display name + color in UI for autocomplete, search preview, entity profile #7785

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(ui): Fix tags display name + color in UI for autocomplete, search preview, entity profile #7785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3f62f
Fix tag display name
jjoyce0510 Apr 10, 2023
477018b
fix bad merge
jjoyce0510 Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/entity/tag/Tag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class TagEntity implements Entity<Tag> {
renderPreview = (_: PreviewType, data: Tag) => (
<DefaultPreviewCard
description={data.description || ''}
name={data.name}
name={this.displayName(data)}
urn={data.urn}
url={`/${this.getPathName()}/${urlEncodeUrn(data.urn)}`}
logoComponent={<PreviewTagIcon />}
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/graphql/fragments.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ fragment globalTagsFields on GlobalTags {
name
description
properties {
name
colorHex
}
}
Expand Down
3 changes: 3 additions & 0 deletions datahub-web-react/src/graphql/search.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ fragment autoCompleteFields on Entity {
name
properties {
name
colorHex
}
}
... on MLFeatureTable {
Expand Down Expand Up @@ -699,6 +700,7 @@ fragment searchResultFields on Entity {
name
properties {
name
colorHex
}
description
}
Expand All @@ -719,6 +721,7 @@ fragment facetFields on FacetMetadata {
... on Tag {
name
properties {
name
colorHex
}
}
Expand Down