Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): prevent republish of images on release edits #7828

Merged
merged 1 commit into from Apr 15, 2023
Merged

fix(release): prevent republish of images on release edits #7828

merged 1 commit into from Apr 15, 2023

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Apr 14, 2023
shirshanka
shirshanka approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 97ac8d9 into datahub-project:master Apr 15, 2023
50 checks passed
@RyanHolstien RyanHolstien deleted the fix/allowReleaseDocEdits branch April 17, 2023 16:34
yoonhyejin pushed a commit that referenced this pull request Apr 19, 2023
@RyanHolstien @socar-dini
fix(ci): prevent republish of images on release edits (#7828)
8bbce47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@david-leifker david-leifker david-leifker approved these changes

@iprentic iprentic Awaiting requested review from iprentic

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RyanHolstien @shirshanka @david-leifker