Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker):Add the jattach tool to the docker container(#7538) #8040

Merged
merged 12 commits into from
Jun 7, 2023

Conversation

yangjiandan
Copy link
Contributor

Test:

  1. docker run -it linkedin/datahub-gms:head /bin/sh
  2. run jattach

The following is a screenshot of the execution in my local environment
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable) - N/A
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub - N/A

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs labels May 15, 2023
@yangjiandan
Copy link
Contributor Author

@meyerkev Thanks very much for your apply in #7539. I update patch using latest code, and add a attach-guide doc.
Could you help review my patch again?

@yangjiandan
Copy link
Contributor Author

all required checks have passed! some checked failed due network timeout and is not related to this modification.
@meyerkev

@yangjiandan
Copy link
Contributor Author

@david-leifker Could you help me review this patch?

@david-leifker david-leifker self-assigned this May 22, 2023
@david-leifker
Copy link
Collaborator

Taking a look here, need to get the docs process to be happy. Lets see if the update from master helps.

@yangjiandan
Copy link
Contributor Author

@david-leifker thanks for your reply, I have fix doc issue. Please help me review this PR again.

@david-leifker david-leifker merged commit 5588a04 into datahub-project:master Jun 7, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants