Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker):Add the jattach tool to the docker container(#7538) #7539

Closed
wants to merge 2 commits into from

Conversation

yangjiandan
Copy link
Contributor

@yangjiandan yangjiandan commented Mar 10, 2023

Test:

  1. docker run -it linkedin/datahub-gms:head /bin/sh
  2. run jattach

The following is a screenshot of the execution in my local environment
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable) - N/A
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub - N/A

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Mar 10, 2023
@yangjiandan
Copy link
Contributor Author

@jjoyce0510 Could you help review this pr?

@meyerkev
Copy link
Contributor

meyerkev commented Apr 10, 2023

First, thank you. This will help all Datahub users debug their Datahub problems.

Conditionally, I am LGTM.

Specifically, are there any README's or other forms of documentation where it would be helpful to make a note that:

  1. We added jattach to our Docker images
  2. How to use jattach against datahub images, targeted at approximately a college new grad who has never used Datahub and is stuck debugging. Specifically, can we get these two lines or something that looks like them into a doc somewhere to make people aware that you can in fact use jattach from within our images?
docker run -it linkedin/datahub-gms:head /bin/sh
run jattach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants